Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): filter fee before filtering by gas limit #707

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(builder): filter fee before filtering by gas limit #707

merged 1 commit into from
May 16, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Filter UOs by fee before applying the bundle gas limit
  • Before, if there are a lot of underpriced UOs (specifically by base fee or PVG, as they're sorted by priority fee) then they'll block correctly priced UOs from making it to the simulation stage.
  • Now, we filter by fee prior to filtering by gas limit. It does add an extra async step, but will improve when we're doing gas limiting.

@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 55.25%. Comparing base (7cc3f5f) to head (a7e5972).

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_proposer.rs 89.04% <74.00%> (+0.01%) ⬆️
Flag Coverage Δ
unit-tests 55.25% <74.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 50.00% <74.00%> (+0.20%) ⬆️
dev 0.00% <ø> (ø)
pool 64.50% <ø> (ø)
provider 16.68% <ø> (ø)
rpc 25.67% <ø> (ø)
sim 77.99% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.27% <ø> (ø)
utils 18.28% <ø> (ø)

dphilipson
dphilipson approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crates/builder/src/bundle_proposer.rs Outdated Show resolved Hide resolved
@dancoombs dancoombs merged commit 02af869 into main May 16, 2024
7 checks passed
@dancoombs dancoombs deleted the danc/fee-filter branch May 16, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-miao alex-miao alex-miao approved these changes

@dphilipson dphilipson dphilipson approved these changes

@0xfourzerofour 0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancoombs @dphilipson @alex-miao